open-source/file-online-preview
1
0
Fork 0
mirror of https://gitee.com/kekingcn/file-online-preview.git synced 2026-11-11 13:50:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(#790): assert JS-escaping of file URL across all 14 preview templates

Browse Source
This commit is contained in:
wylovely
2026-09-24 15:41:22 +08:00
parent 016a040461
commit ae7cdf3963
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
server/src/test/java/cn/keking/PdfViewerCompatibilityTests.java
View File

@@ -76,14 +76,22 @@ public class PdfViewerCompatibilityTests {
}
@Test
void shouldEscapeFileUrlWithJsStringInPreviewTemplates() throws IOException {
void shouldEscapeFileUrlWithJsStringInAllPreviewTemplates() throws IOException {
// Regression test for #790: a single quote in the source file URL (e.g. a path
// segment like "Int'l") was interpolated raw into the inline `var url = '...'`
// assignment, terminating the JS string early and throwing Uncaught SyntaxError.
// FreeMarker's ?js_string built-in escapes it for the JS string literal context.
String pdfTemplate = readResource("/web/pdf.ftl");
assertTrue(pdfTemplate.contains("var url = '${finalUrl?js_string}';"),
() -> "pdf.ftl must JS-escape the file URL to avoid SyntaxError on apostrophe (see #790)");
// Every preview template that injects the file URL into a JS string literal must
// use ?js_string, otherwise a URL containing an apostrophe breaks the page.
String[] previewTemplates = {
"bpmn", "csv", "dcm", "drawio", "eml", "epub", "msg", "ofd",
"officeweb", "online3D", "pdf", "svg", "tiff", "xmind"
};
for (String name : previewTemplates) {
String template = readResource("/web/" + name + ".ftl");
assertTrue(template.contains("var url = '${finalUrl?js_string}';"),
() -> name + ".ftl must JS-escape the file URL to avoid SyntaxError on apostrophe (see #790)");
}
}
private String readResource(String resourcePath) throws IOException {