open-source/file-online-preview
1
0
Fork 0
mirror of https://gitee.com/kekingcn/file-online-preview.git synced 2026-11-13 06:40:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(#790): add regression test asserting file URL is JS-escaped in preview template

Browse Source
This commit is contained in:
wylovely
2026-09-22 09:17:43 +08:00
parent 6fa1d91296
commit 016a040461
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server/src/test/java/cn/keking/PdfViewerCompatibilityTests.java
View File

@@ -75,6 +75,17 @@ public class PdfViewerCompatibilityTests {
assertTrue(properties.contains("office.preview.type = ${KK_OFFICE_PREVIEW_TYPE:pdf}")); assertTrue(properties.contains("office.preview.type = ${KK_OFFICE_PREVIEW_TYPE:pdf}"));
} }
@Test
void shouldEscapeFileUrlWithJsStringInPreviewTemplates() throws IOException {
// Regression test for #790: a single quote in the source file URL (e.g. a path
// segment like "Int'l") was interpolated raw into the inline `var url = '...'`
// assignment, terminating the JS string early and throwing Uncaught SyntaxError.
// FreeMarker's ?js_string built-in escapes it for the JS string literal context.
String pdfTemplate = readResource("/web/pdf.ftl");
assertTrue(pdfTemplate.contains("var url = '${finalUrl?js_string}';"),
() -> "pdf.ftl must JS-escape the file URL to avoid SyntaxError on apostrophe (see #790)");
}
private String readResource(String resourcePath) throws IOException { private String readResource(String resourcePath) throws IOException {
try (InputStream inputStream = getClass().getResourceAsStream(resourcePath)) { try (InputStream inputStream = getClass().getResourceAsStream(resourcePath)) {
assertNotNull(inputStream); assertNotNull(inputStream);